Reopen Closed Tab

Discuss development issues and submit patches here
Post Reply
twinsen
Posts: 109
Joined: Mon Dec 27, 2010 3:17 pm

Reopen Closed Tab

Post by twinsen » Fri Jan 07, 2011 12:33 am

Here is a feature you may be familiar with from browsers.
Example exe: http://members.iinet.net.au/~bertdb/rya ... n_1.5.1.7z
Patch attached
Attachments
ReopenClosedTab_v187_patch.7z
(2.29 KiB) Downloaded 409 times
ReopenClosedTab_v159.7z
(2.15 KiB) Downloaded 395 times
Last edited by twinsen on Sun Feb 06, 2011 7:41 pm, edited 3 times in total.

ajs
Posts: 409
Joined: Mon Jul 05, 2010 6:37 pm

Re: Reopen Closed Tab

Post by ajs » Fri Jan 07, 2011 10:18 am

Hi twinsen,
very good, such command was also on my list of "things to do". I didn't check the code yet, but I tried the executable and I like that.
After David commits a few of the pending patches, I am planning to re-arrange the main menu, addind a "Tab" menu which groups all the tab commands (create new, duplicate, move to new window, etc....).

ajs
Posts: 409
Joined: Mon Jul 05, 2010 6:37 pm

Re: Reopen Closed Tab

Post by ajs » Fri Jan 07, 2011 6:21 pm

Hi twinsen,
I tried your code but it crashed when trying to duplicate tabs or re-open new tabs.
I found the problem in the code and fixed that.
I also added the code to enable the "reopen closed tab" menu entry only if at least a tab has been closed (i.e. m_closedTabs.size > 0)

Here is the patch, against commit 161

2011/12/11 Patch file updated. The "reopen close tab" command has been moved up the menu. Now it is after the "duplicate tab" command
Attachments
patch_15__v161.7z
(2.2 KiB) Downloaded 406 times

David Erceg
Site Admin
Posts: 887
Joined: Sat Apr 18, 2009 1:46 am
Location: Australia

Re: Reopen Closed Tab

Post by David Erceg » Tue Apr 12, 2011 2:05 am

Patch rejected.

CovenStine
Posts: 2
Joined: Wed Feb 06, 2013 7:27 am

Re: Reopen Closed Tab

Post by CovenStine » Wed Feb 13, 2013 3:12 am

This would be a very useful feature, especially if implemented with the Firefox/Chrome default of [Ctrl]+[F4] Closes a tab and [Ctrl]+[Shift]+[T] reopens it.
Is it never going to be used?
I doubt I'm the only user that would use it...

welp
Posts: 1
Joined: Tue Jan 23, 2018 6:44 pm

Re: Reopen Closed Tab

Post by welp » Tue Jan 23, 2018 6:50 pm

What was this development rejected?
Kinda blunt there David.

Post Reply