Address Bar Filter

Discuss development issues and submit patches here
Post Reply
twinsen
Posts: 109
Joined: Mon Dec 27, 2010 3:17 pm

Address Bar Filter

Post by twinsen »

I modified Explorer++ so that I can just type eg "\*.cpp" on the end of the address bar to change the filter. This is similar behaviour to the way 2xExplorer works.
Here is the exe so people can see what it is like:
http://members.iinet.net.au/~bertdb/rya ... ter_mod.7z
It is easy to use without requiring another text box or dialog.

I haven't created a patch, but if you are interested in the kind of code changes that were made, you can look at this:
http://members.iinet.net.au/~bertdb/rya ... hanges.txt

ajs
Posts: 409
Joined: Mon Jul 05, 2010 6:37 pm

Re: Address Bar Filter

Post by ajs »

Hi Twinsen,
the functionality you introduce with your change looks quite interesting! GOOD IDEA!
If you could make up a patch I'm sure it would be easier and quicker for David to merge that one in. Alternatively you could post a zip file with the source files you changed (in full) since a compare-and-merge is quite quick as well

twinsen
Posts: 109
Joined: Mon Dec 27, 2010 3:17 pm

Re: Address Bar Filter

Post by twinsen »

Here is the patch (attached) which can be applied to the head of the svn repository (R156).
I also fixed it to support paths not containing \*, eg: explorer++_1.2_src\Explorer++\Explorer++\Address*.cpp
(previous links also updated).
Attachments
AddressBarFilter_R156_patch.7z
(2.19 KiB) Downloaded 380 times

twinsen
Posts: 109
Joined: Mon Dec 27, 2010 3:17 pm

Re: Address Bar Filter

Post by twinsen »

Found a minor bug.
When using file:// paths, the slash is a forward slash which breaks the filter.

Improvements:
It would also be better if it was persistent.
We could have a right click to quickly remove the filter (instead of simply changing directories).

ajs
Posts: 409
Joined: Mon Jul 05, 2010 6:37 pm

Re: Address Bar Filter

Post by ajs »

Hi twinsen,
my idea for filter is to introduce a "filter" toolbar. in this toolbar we can put a field for the filter and a button to apply/remove the filter. Also I want to introduce multiple-filters, for example typing "*.h, *.cpp" would select all .h adn .cpp files. At a later stage we can add options for case sensitive/insensitive, regex filter, exact match. And finally I want to add the ability to save the most used filters, so they can be easily re-used.
This is my plan and I hope I can start working on this within the end of the month. Before that I have some other things I want to fix or implement.
What do you think? If you have more ideas, just add them in.

twinsen
Posts: 109
Joined: Mon Dec 27, 2010 3:17 pm

Re: Address Bar Filter

Post by twinsen »

Yeah it sounds good. I'll wait and see how it feels.
I based mine on what 2xExplorer does, as I found it easiest to use of the gui explorers.
I'm also used to the filespec filters that existed in old file managers like xtree and ztree. The ctrl-shift-f is pretty close to that and feels good for a gui.

ajs
Posts: 409
Joined: Mon Jul 05, 2010 6:37 pm

Re: Address Bar Filter

Post by ajs »

I will check what xtree, ztree and 2xExplorer do before starting implementation. Good ideas are always welcome.
A tentative road map is this:
1) extend the existing filter window (Ctrl+Shift+F) to add case sensitive/insensitive, regex filter, exact match, multiple filters
2) add the filter toolbar, which would have the filter field, the "apply filter" button and one more button to open the filter window. The filter toolbar would use the settings chosen from the filter window.
3) add the ability to save the most recently used filters in the filter window

Meanwhile we also keep the "address bar filter" function that you implemented.

Post Reply