Drive Toolbar Improvements

Discuss development issues and submit patches here
ajs
Posts: 409
Joined: Mon Jul 05, 2010 6:37 pm

Re: Drive Toolbar Improvements

Post by ajs »

Hi David,
I have rework patch 06B following your suggestions.
I have temporarily removed the code which checks for floppy drives, so the rest of the patch can be committed.
Patch against commit 186

As a further note about the check for the floppy drive originally proposed by Ryan (twinsen), honestly I don't see the reason why you don't want to commit it. Maybe checking the drive type is not the most elegant solution, but as far as I understand from Ryan, it works (and Ryan is not the only user who has complained about the delay to check for floppies). And if you think about it, E++ already does a similar thing for remote hard drives.
if(GetDriveType(szDrive) != DRIVE_REMOTE)

Alternatively, I have two possible ideas for it:
1) we add a user option to "disable floppy type check", so the user can choose to enable or disable the drive type check for floppies
2) we use GetDriveType instead of SHGetFileInfo to check for removable drives. Anyhow, in this case we affects every removable drives (i.e. USB, floppies...) and not only the floppies.
Attachments
patch_06B__v186.7z
(5.85 KiB) Downloaded 776 times
ajs
Posts: 409
Joined: Mon Jul 05, 2010 6:37 pm

Re: Drive Toolbar Improvements

Post by ajs »

Small update for this patch.
After setting the label on the drives toolbar, the toolbar size has to be updated as well.
Also two functions not used have been removed.

Patch against commit 188
Attachments
patch_06B__v188.7z
(6.32 KiB) Downloaded 799 times
Post Reply