Move tab to new window

Discuss development issues and submit patches here
David Erceg
Site Admin
Posts: 909
Joined: Sat Apr 18, 2009 1:46 am

Re: Move tab to new window

Post by David Erceg »

I'm ready to commit this change, but there's definitely a bug in ProcessTabCommand(). It looks like most (I haven't checked all of them) of the handlers are using iTabHit as an internal index, rather than a tab index. My fault really, so I'll fix it up.

About the minidump feature, it's already active (and finished). When there's a crash, you should get a file with a name similar to Explorer++1.2-22012011-191733.dmp within the %temp% directory. The only thing that's commented out within MyUnhandledExceptionFilter() is the custom error message that would be shown. I felt it was better simply to allow Windows to show the standard crash dialog.

twinsen
Posts: 109
Joined: Mon Dec 27, 2010 3:17 pm

Re: Move tab to new window

Post by twinsen »

Fixed the internal tab index conversion, updated patch to revision 177.
Attachments
patch v187 Move tab to new window.7z
(1.06 KiB) Downloaded 337 times
patch v177 Move tab to new window (internal tab index fix).7z
(1.11 KiB) Downloaded 332 times
Last edited by twinsen on Sun Feb 06, 2011 7:52 pm, edited 2 times in total.

ajs
Posts: 409
Joined: Mon Jul 05, 2010 6:37 pm

Re: Move tab to new window

Post by ajs »

Hi twinsen,
well done first of all.
I have updated your patch since I found the same problem in the refreshTab method. Also fix a string name problem: duplicatetonewwindow was mispelled (dulicatetonewwindow)
Attachments
patch_07__v177.7z
(1.25 KiB) Downloaded 296 times

ajs
Posts: 409
Joined: Mon Jul 05, 2010 6:37 pm

Re: Move tab to new window

Post by ajs »

Hi twinsen,
after applying the last (corrected) patch 07, the bug seems to have disappeared.
Can you try as well on your side?

Maybe the crash was caused by the use of the wrong tab index with the previous version of the patch.

David Erceg
Site Admin
Posts: 909
Joined: Sat Apr 18, 2009 1:46 am

Re: Move tab to new window

Post by David Erceg »

The crash was caused by the tab index been used as an internal reference, as I mentioned above. Please don't submit any patches for the issue, as I'll fix it up.

David Erceg
Site Admin
Posts: 909
Joined: Sat Apr 18, 2009 1:46 am

Re: Move tab to new window

Post by David Erceg »

Michael, your update to RefreshTab() is incorrect - the method is called from multiple places, all with a tab id. It's only from within ProcessTabCommand() that it's been called with a tab index. Please update the patch.

ajs
Posts: 409
Joined: Mon Jul 05, 2010 6:37 pm

Re: Move tab to new window

Post by ajs »

David Erceg wrote:Michael, your update to RefreshTab() is incorrect - the method is called from multiple places, all with a tab id. It's only from within ProcessTabCommand() that it's been called with a tab index. Please update the patch.
Ok, tomorrow I will fix it. To be honest I had done this patch update very quickly and missed that. My fault really :(

ajs
Posts: 409
Joined: Mon Jul 05, 2010 6:37 pm

Re: Move tab to new window

Post by ajs »

This time I gave it the right time, checked the code and properly debugged.
Fixed the problem with the refresh.

Patch updated to commit 188
Attachments
patch_07__v188.7z
(1.03 KiB) Downloaded 301 times

Post Reply