Page 2 of 2

Re: Move tab to new window

Posted: Sat Jan 22, 2011 6:20 pm
by David Erceg
I'm ready to commit this change, but there's definitely a bug in ProcessTabCommand(). It looks like most (I haven't checked all of them) of the handlers are using iTabHit as an internal index, rather than a tab index. My fault really, so I'll fix it up.

About the minidump feature, it's already active (and finished). When there's a crash, you should get a file with a name similar to Explorer++1.2-22012011-191733.dmp within the %temp% directory. The only thing that's commented out within MyUnhandledExceptionFilter() is the custom error message that would be shown. I felt it was better simply to allow Windows to show the standard crash dialog.

Re: Move tab to new window

Posted: Sat Jan 29, 2011 2:58 pm
by twinsen
Fixed the internal tab index conversion, updated patch to revision 177.

Re: Move tab to new window

Posted: Sat Jan 29, 2011 6:03 pm
by ajs
Hi twinsen,
well done first of all.
I have updated your patch since I found the same problem in the refreshTab method. Also fix a string name problem: duplicatetonewwindow was mispelled (dulicatetonewwindow)

Re: Move tab to new window

Posted: Sat Jan 29, 2011 6:43 pm
by ajs
Hi twinsen,
after applying the last (corrected) patch 07, the bug seems to have disappeared.
Can you try as well on your side?

Maybe the crash was caused by the use of the wrong tab index with the previous version of the patch.

Re: Move tab to new window

Posted: Sat Jan 29, 2011 7:39 pm
by David Erceg
The crash was caused by the tab index been used as an internal reference, as I mentioned above. Please don't submit any patches for the issue, as I'll fix it up.

Re: Move tab to new window

Posted: Sun Jan 30, 2011 2:34 am
by David Erceg
Michael, your update to RefreshTab() is incorrect - the method is called from multiple places, all with a tab id. It's only from within ProcessTabCommand() that it's been called with a tab index. Please update the patch.

Re: Move tab to new window

Posted: Mon Jan 31, 2011 12:06 am
by ajs
David Erceg wrote:Michael, your update to RefreshTab() is incorrect - the method is called from multiple places, all with a tab id. It's only from within ProcessTabCommand() that it's been called with a tab index. Please update the patch.
Ok, tomorrow I will fix it. To be honest I had done this patch update very quickly and missed that. My fault really :(

Re: Move tab to new window

Posted: Wed Feb 09, 2011 5:30 pm
by ajs
This time I gave it the right time, checked the code and properly debugged.
Fixed the problem with the refresh.

Patch updated to commit 188