Patch to refresh the TV correctly when changing zip files

Discuss development issues and submit patches here
Post Reply
ajs
Posts: 409
Joined: Mon Jul 05, 2010 6:37 pm

Patch to refresh the TV correctly when changing zip files

Post by ajs »

Patch for refreshing the treeview correctly when creating, renaming, deleting zip files.

The patch is very small (just a line of ocde): the directory monitoring thread needs to check not only for FILE_NOTIFY_CHANGE_DIR_NAME (folder changes), but also for FILE_NOTIFY_CHANGE_FILE_NAME. This allow the treeview to monitor file name changes and update the zip files correctly. The changes to other files are ignored since they are not shown in the treeview.
This patch does introduce some problems with files added to the treeview when they are created after the treeview item has been expanded. A fix will follow soon.
Attachments
patch_20__v163.7z
(483 Bytes) Downloaded 393 times

ajs
Posts: 409
Joined: Mon Jul 05, 2010 6:37 pm

Re: Patch to refresh the TV correctly when changing zip files

Post by ajs »

Patch to fix the problem caused by patch 20.
After applying patch 20, creating new files would cause them to be added to the treeview.
This patch fixes the problem. It also stops zip files to be added to the treeview if the "show zip files as folders" option is disabled.
Th patch is against commit 163 + patch 19 + patch 20 + patch 24.
Attachments
patch_28__v163.p19.p20.p24.7z
(2.65 KiB) Downloaded 380 times

David Erceg
Site Admin
Posts: 909
Joined: Sat Apr 18, 2009 1:46 am

Re: Patch to refresh the TV correctly when changing zip files

Post by David Erceg »

I'm in favour of adding/removing zip files when needed, but not anything else outside of that (no hiding of zip files). Rework the patch and I'll commit it.

Post Reply