Patch for bookmarks - 1

Discuss development issues and submit patches here
Post Reply
ajs
Posts: 409
Joined: Mon Jul 05, 2010 6:37 pm

Patch for bookmarks - 1

Post by ajs »

Patch for bookmarks.

This patch is for:
1) the "delete bookmark" logic was incorrect. In case of (sub)folders, bookmarks were not deleted correctly. Also, deleting and empty folder would crash E++
2) add button "delete all" bookmarks to the "organize bookmark" dialog.

Patch against commit 188.

There is more to do and fix about bookmarks, so there will be more patches for that.
Attachments
patch_44__v188.7z
(2.99 KiB) Downloaded 458 times
David Erceg
Site Admin
Posts: 936
Joined: Sat Apr 18, 2009 1:46 am

Re: Patch for bookmarks - 1

Post by David Erceg »

Sorry Michael, I should of said earlier, but don't do any work on bookmarks. I plan on redoing the entire thing.
ajs
Posts: 409
Joined: Mon Jul 05, 2010 6:37 pm

Re: Patch for bookmarks - 1

Post by ajs »

Hi David,
that is good news. The code for the bookmarks is quite old I guess (by the look of it) and rewriting all of it is definitely a good idea and something I thought about as well.
My plan was to write a "session manager" from scratch and then re-do the bookmark on the same guideline.
Post Reply