Patch for bookmark - 2: bookmark toolbar

Discuss development issues and submit patches here
Post Reply
ajs
Posts: 409
Joined: Mon Jul 05, 2010 6:37 pm

Patch for bookmark - 2: bookmark toolbar

Post by ajs »

Patch for bookmark - 2

The bookmark toolbar didn't display any bookmark at all. This patch fixes the problem.

I have to say this is not the "best way" to fix the problem, it is more a real patch.
For some reasons, if the bookmark toolbar is created with the TBSTYLE_EX_HIDECLIPPEDBUTTONS style flag, it hides all the buttons, as if they were all clipped.
I spent quite a long time to check the code, also comparing with the code for the application toolbar and the drives toolbar. But couldn't figure out what is wrong. Choosing to display only the button icon without any text is fine though.
As I said, not sure why this is happening, but at least with this patch the bookmark toolbar is usable again. The patch is really small, just a line of code. I am going to do more work on bookmarks, so I will probably give it another try as well.

Patch against commit 188
Attachments
patch_45__v188.7z
(453 Bytes) Downloaded 521 times
Post Reply