Patch for scrolling the tabctrl correctly
The range of the tabctrl was not updated correctly when creating/deleting tabs, so scrolling of the tabctrl was not 100% possible. Also closing all visible tabs was causing problems (empty tab control even though hidden tab existed).
Patch against commit 195
Patch for scrolling the tabctrl correctly
Patch for scrolling the tabctrl correctly
- Attachments
-
- patch_54__v195.zip
- (1.27 KiB) Downloaded 531 times
-
- Site Admin
- Posts: 936
- Joined: Sat Apr 18, 2009 1:46 am
Re: Patch for scrolling the tabctrl correctly
What precisely is the bug here? I'm also not sure what you mean by closing all visible tabs (the tab control is never empty)?
Also, unless there's a bug in Windows, I don't see why the tab control itself wouldn't be able to update it's own range?
Also, unless there's a bug in Windows, I don't see why the tab control itself wouldn't be able to update it's own range?
Re: Patch for scrolling the tabctrl correctly
I will explain with an example using the last nightly built version.
BUG 1
1) open E++, let's imagine it has a single tab open at the beginning. Create 2 or more tabs. Now try to scroll the tabs on the tab control using the mouse wheel when the mouse cursor is over the tab control. You should see that scrolling is not working.
2) now close and reopen E++ and try to scroll again. You should see that scrolling the tabs is now possible.
BUG 2
1) open E++ and creates a few tabs. close and reopen E++ as explained above, so that scrolling is possible.
2) select any tab but the last one and then scroll the tabs with the mouse wheel so that only the last tab is visible 3) right-click on the tab and close the last tab (which was not selected, it is the key). The tab control displays no tabs, even though the other tabs are still there (and the listview is actually displaying the contents of the selected-but-hidden tab) I hope this is more clear. The patch fixes these problems
BUG 1
1) open E++, let's imagine it has a single tab open at the beginning. Create 2 or more tabs. Now try to scroll the tabs on the tab control using the mouse wheel when the mouse cursor is over the tab control. You should see that scrolling is not working.
2) now close and reopen E++ and try to scroll again. You should see that scrolling the tabs is now possible.
BUG 2
1) open E++ and creates a few tabs. close and reopen E++ as explained above, so that scrolling is possible.
2) select any tab but the last one and then scroll the tabs with the mouse wheel so that only the last tab is visible 3) right-click on the tab and close the last tab (which was not selected, it is the key). The tab control displays no tabs, even though the other tabs are still there (and the listview is actually displaying the contents of the selected-but-hidden tab) I hope this is more clear. The patch fixes these problems